Skip to content

Fix remove redundant component label added for backward compatibility with upgrade tests#1187

Merged
shivamerla merged 1 commit into
kubernetes-sigs:mainfrom
shivamerla:fix_duplicate_component_label
Jun 11, 2026
Merged

Fix remove redundant component label added for backward compatibility with upgrade tests#1187
shivamerla merged 1 commit into
kubernetes-sigs:mainfrom
shivamerla:fix_duplicate_component_label

Conversation

@shivamerla

@shivamerla shivamerla commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fix remove redundant component label added for backward compatibility with upgrade tests

  • As part of GitHub issue Helm chart: keep supporting nvidia-dra-driver-gpu-component label for now #1079 we had introduced redundant component label in both kubelet plugin and CD controller.
  • This was mainly for compatibility with upgrade tests (checkpoint validation). However, this caused duplicate keys to be rendered and parser validation failures with GitOps like ArgoCD/FluxCD.
  • Now that we have a stable release in upstream registries, we can safely remove this label with previous name.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR is related to:

Fixes: #1184

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Resolved an issue where redundant component labels caused errors when Helm templates were rendered with strict parsing in GitOps tools such as ArgoCD.

Additional documentation (design docs, usage docs, etc.):

Checklist

  • make check test passes locally
  • make check-generate passes if api/ changed (CRDs, deepcopy, informers, listers, clientset)
  • make check-modules passes if go.mod / go.sum changed
  • Tests added or updated for the change
  • Helm chart (deployments/helm) updated if flags, RBAC, or defaults changed

@shivamerla
Fix remove redundant component label added for backward compatibility…
af356f9 
… with upgrade tests

* As part of GitHub issue kubernetes-sigs#1079 we had introduced redundant component label in both kubelet plugin and CD controller.
  This was mainly for compatibility with upgrade tests (checkpoint validation)
* However, this caused duplicate keys to be rendered and parser validation failures with GitOps like ArgoCD/FluxCD.
* Now that we have a stable release in upstream registries, we can safely remove this label with previous name.

Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
@shivamerla shivamerla force-pushed the fix_duplicate_component_label branch from c0c76dc to af356f9 Compare June 10, 2026 15:42
@shivamerla shivamerla self-assigned this Jun 10, 2026
@shivamerla shivamerla requested review from dims and varunrsekar June 10, 2026 15:52
@shivamerla

shivamerla commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-0.4

@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit c0c76dc
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a2985a4b6d13400084a6dc3

1 similar comment
@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit c0c76dc
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a2985a4b6d13400084a6dc3

@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit af356f9
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a2985d586e40b0008403d69

1 similar comment
@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ Deploy Preview for dra-driver-nvidia-gpu canceled.

Name Link
🔨 Latest commit af356f9
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a2985d586e40b0008403d69

@k8s-triage-robot

k8s-triage-robot commented Jun 10, 2026

Copy link
Copy Markdown

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2026
@ameukam

ameukam commented Jun 10, 2026

Copy link
Copy Markdown
Member

/retest

@haarchri haarchri mentioned this pull request Jun 10, 2026
Open
25 tasks
@varunrsekar

varunrsekar commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@k8s-ci-robot

k8s-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, shivamerla, varunrsekar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dims,shivamerla,varunrsekar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2026
@k8s-ci-robot

k8s-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: cf70b33480b6977f1b51f00b8c9d63ed12c45296

@shivamerla

shivamerla commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/skip tests {mock tests are failing due to go-nvlib dependency to be fixed soon}

@shivamerla shivamerla merged commit b6d359b into kubernetes-sigs:main Jun 11, 2026
14 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in DRA Driver for NVIDIA GPUs Jun 11, 2026
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Jun 11, 2026

Copy link
Copy Markdown

@shivamerla: new pull request created: #1193

Details

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 11, 2026
Merged
@haarchri

haarchri commented Jun 12, 2026

Copy link
Copy Markdown

@shivamerla can we cut an RC version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@varunrsekar varunrsekar Awaiting requested review from varunrsekar

Assignees

@varunrsekar varunrsekar

@shivamerla shivamerla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

DRA Driver for NVIDIA GPUs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate pod-template label key when nameOverride is "nvidia-dra-driver-gpu"

8 participants

@shivamerla @k8s-triage-robot @ameukam @varunrsekar @k8s-ci-robot @k8s-infra-cherrypick-robot @haarchri @dims